Remove ControllerMock #1948 (backport #1990) #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit a04416d)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #1991 +/- ##
===========================================
- Coverage 87.00% 62.83% -24.18%
===========================================
Files 97 109 +12
Lines 7505 12592 +5087
Branches 677 8552 +7875
===========================================
+ Hits 6530 7912 +1382
- Misses 688 864 +176
- Partials 287 3816 +3529
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at the #1948, and indeed this is an overload and not a overrided method. There is no update method that takes zero arguments. Nevertheless, I've checked and this code is not used in ros2_control nor in any other ros2_control repo. I think this might be deleted.
This is an automatic backport of pull request #1990 done by Mergify.